[Github-comments] [geany/geany] Cleanup sorting tabs (b1528f0)

[konsolebox]

Here I used `cmp = compare_docs_by_filename(&doc_a, &doc_b);` instead.

I think it's still better to not skip getting the basename of the file's path, since `get_doc_path()` might return similar `dirname`'s for files opened with `~` argument and `/home/user`, and comparing the two alike pathnames having different actual `dirname`'s would make a different comparison result.

I'm not sure how `get_doc_folder` actually behaves, but it would better to just wrap it up anyway so that any changes that may happen in `get_doc_folder` in the future would not affect the compare functions.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/b1528f01e240379c0f75ae0c2f50829b271c0f30#commitcomment-18463862
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160731/59ab0c86/attachment.html>