[Github-comments] [geany/geany] Add features for sorting editor tabs (#1144)

[Colomban Wendling]

> I actually just copied it to avoid more intrusion.  I'm just waiting for a go signal so I could place it somewhere else like `utils.c`.  How should we share the code?  As what I've suggested, we can place it in `utils.h`.  Or should we just place it in `sidebar.c` and have `notebook.c` include `sidebar.h`?

I guess keeping it in sidebar would make more sense: it's not really anything generic, it's highly specific to how the sidebar works.  In that sense what you would really want to share is the sorting order, but you can't too easily do that -- apart maybe by being able to get the document list as sorted in the sidebar, and apply that very order.

> Also, should we add a prefix to `get_doc_folder`? Like `utils_get_doc_folder` or `sidebar_get_doc_folder`?

yes, all functions added to headers -- event internally -- need to be prefixed.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1144#issuecomment-236389676
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160730/20dfad40/attachment.html>