[Github-comments] [geany/geany] Add keywords to the autocompletion list (#1146)

[Jiří Techet]

I repushed the patches with the possibility to enable/disable autocompletion for certain keyword groups. In general I kept autocompletion enabled for everything that seemed to be keyword (type or whatever) in the given language. It's off only for things like docstrings, languages embedded inside HTML and when the keyword group is a specific subset of a language which isn't commonly used (SGML keywords in XML).

XML, PHP and Zephir are using HTML keywords - I had to modify PHP (which means Zephir too) to perform autocompletion for PHP keywords (which differs from HTML where the PHP keywords aren't autocompleted). I also kept HTML autocompletion for PHP files because most commonly they are a HTML (I can change it if anyone thinks it's a bad idea).

As I had to access HLKeyword I would have to make it accessible in StyleSet to be able to perform the check whether to use the given keyword group; instead I decided to construct the autocompletion keyword list already when initializing languages which also reduces the amount of time spent later when performing autocompletion.

Finally I changed the icon in the popup to "classviewer-member" which looks better IMO.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1146#issuecomment-234762435
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160724/12239497/attachment.html>