[Github-comments] [geany/geany] Add features for sorting editor tabs (#1144)

Colomban Wendling notifications at xxxxx
Sat Jul 23 21:33:23 UTC 2016


> My concern was that: having the sort function called from a one-call-per-file function means that the sort function would be called everytime a file is opened, even in a batch operation when it should only be called once.

Mmmokay, but that's probably also premature optimization, it's not likely to be *that* slow.

And as said in an inline comment, you could avoid sorting everything and only sort the new document's tab.

> >  should use Stash for new settings!
>
>I just followed how other things were arranged, but I'll see how that can necessarily be done.

at the top of `save_dialog_prefs()` you can read `/* new settings should be added in init_pref_groups() */` ;)

> As I examined it right now, `show_tab_bar_popup_menu()` doesn't even create any hooks or signals that would allow plugins to create their own menu items.

No indeed, that's not currently possible AFAIK.

> I can consider converting this to a plugin if it's necessary, but personally I'd prefer that it becomes part of Geany and not a plugin, since it directly affects the main behavior of the UI, and not just something that alters the content of the document, or adds another tab in the sidebar. If this is created as a plugin, the plugin would possibly require to be highly adaptive to changes in the UI code.

Possibly fair point.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1144#issuecomment-234741679
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160723/69e130ac/attachment.html>


More information about the Github-comments mailing list