[Github-comments] [geany/geany] Add keywords to the autocompletion list (#1146)

[Colomban Wendling]

> @@ -1776,3 +1776,23 @@ gboolean highlighting_is_code_style(gint lexer, gint style)
>  	return !(highlighting_is_comment_style(lexer, style) ||
>  		highlighting_is_string_style(lexer, style));
>  }
> +
> +
> +gchar **highlighting_get_keywords(GeanyFiletypeID filetype_id)
> +{
> +	GString *str = g_string_sized_new(1000);
> +	gchar **keywords;
> +	gchar **keyword_str;
> +
> +	foreach_strv(keyword_str, style_sets[filetype_id].keywords)

yet your example replacement has a bug, it doesn't handle `NULL`, which I wouldn't find unexpected in this context (and may even be a valid strv, not sure from the top of my head) :)

But yeah, those macros don't really make the code clearer.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1146/files/1e74c11aca41274d690d8da0b6e59b1247fbb222#r71972353
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160723/67937812/attachment.html>