[Github-comments] [geany/geany] Add appdata file and make it known to Makefile.am (#1142)

Colomban Wendling notifications at xxxxx
Wed Jul 20 16:52:43 UTC 2016


> @@ -17,6 +17,7 @@ WIN32_BUILD_FILES = \
>  EXTRA_DIST = \
>  	autogen.sh \
>  	scripts/gen-api-gtkdoc.py \
> +        geany.appdata.xml.in \

Sure, because  GitHub uses tab stops of 8 and doesn't display tabs or spaces themselves, so it alignes,but it should be exactly one tab like the other lines, not 4 spaces.  And you can see in the diff that it's not aligned.

```diff
diff --git a/Makefile.am b/Makefile.am
index c5d2a90..ffa9b33 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -17,7 +17,7 @@ WIN32_BUILD_FILES = \
 EXTRA_DIST = \
 	autogen.sh \
 	scripts/gen-api-gtkdoc.py \
-        geany.appdata.xml.in \
+	geany.appdata.xml.in \
 	geany.desktop.in \
 	geany.pc.in \
 	geany.spec \
@@ -87,8 +87,7 @@ desktop_in_files = geany.desktop
 desktop_DATA = $(desktop_in_files:.desktop.in=.desktop)
 @INTLTOOL_DESKTOP_RULE@
 
-appdata_in_files = geany.appdata.xml.in
-
 appdatadir = $(datadir)/appdata
+appdata_in_files = geany.appdata.xml.in
 nodist_appdata_DATA = $(appdata_in_files:.xml.in=.xml)
 @INTLTOOL_XML_RULE@
```

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1142/files/7097a9db8ca5b031667c451d4e8802ee35047cd4#r71563112
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160720/f4f4c825/attachment.html>


More information about the Github-comments mailing list