[Github-comments] [geany/geany] automatically 'Reload the current file from disk' upon external modificati­on (#301)

Ben Wiederhake notifications at xxxxx
Thu Jul 14 22:55:44 UTC 2016


Hmm, that doesn't look as trivial as I hoped for.  Here are some observations:
- The best position would probably be right below the "Disk check timeout" option, probably named "Automatic reload".
- That GUI element is defined in `data/geany.glade:4596`, so for a new property, this file would need to be touched.  `HACKING` seems to recommend Glade 3.8.5, so I'll go with that.
- The correlation to internal keys seems to be done in `src/keyfile.c:222`, so for a new property, this file would need to be touched.
- When a file is deemed reload-necessary, `monitor_reload_file` in `src/document.c:3606` seems to be called to trigger the notification.  So for the new property, this function would need to be touched.
- Apparently, this uses the "new 'simple' prefs", as `src/prefs.c` puts it, so this file would need no changes.

Does this so far sound like a good idea?  I'm new to the project, so I'd like to hear feedback whether a PR changing these places would have hopes of being accepted.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/301#issuecomment-232816067
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160714/c59c3405/attachment.html>


More information about the Github-comments mailing list