[Github-comments] [geany/geany] Don't require plugin key group name and label strings to be static (#1126)

[Colomban Wendling]

> Could also remove the cast entirely if it used the same ownership semantic for all key groups. Trades a teeny bit of performance for a small code perfume :)

Yeah maybe it'd be better indeed.  We don't do that for key items just yet though (yet it bit me already in #1058).

> Otherwise it looks OK, assuming no plugins do weird things like identity (pointer) compares with the keygroup names assuming they're going to be the ones they passed in.

All `GeanyKeyGroup` is totally private, so I don't think there's a way to access that string anyway; and as @elextr said, nobody should even try that.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1126#issuecomment-231344779
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160708/92d61eb6/attachment.html>