[Github-comments] [geany/geany] Don't require plugin key group name and label strings to be static (#1126)

Colomban Wendling notifications at xxxxx
Thu Jul 7 16:01:20 UTC 2016


Take a copy of the strings not to requires them to live live as long as the plugin does.

This is mostly useful for plugins implemented in dynamic languages (e.g. through a plugin proxy), as most C plugins will use a static string; but it makes the API more straightforward and avoids off issues if any plugin doesn't use static strings, even C ones.

Closes #1125.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1126

-- Commit Summary --

  * Don't require plugin key group name and label strings to be static

-- File Changes --

    M src/keybindings.c (7)
    M src/keybindingsprivate.h (4)

-- Patch Links --

https://github.com/geany/geany/pull/1126.patch
https://github.com/geany/geany/pull/1126.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1126
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160707/5bc5b1a2/attachment.html>


More information about the Github-comments mailing list