[Github-comments] [geany] Rewrite scope completion 3 (#862)

Jiří Techet notifications at xxxxx
Tue Jan 26 15:29:16 UTC 2016


@b4n Yep, I think it's really that simple. I'd just do one thing - rename the strip_scope() to something like strip_type() and move also the 

```
g_strdelimit(tag_type, "*^", ' ');
```

line there so it gets rid of pointers in all cases too. I'd also would move the tag->var_type == NULL check inside the strip_type() function so the caller doesn't have to care what var_type contains. Is it OK if I modify it this way?

In the future it would be good to extend the strip_type() function to remove stuff between < and > (stripping templates) and also between [ and ] (stripping arrays). But I'll do this separately from this patchset.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/862#issuecomment-175078508
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160126/bdf388ad/attachment.html>


More information about the Github-comments mailing list