[Github-comments] [geany] Gboxed types (#839)

Thomas Martitz notifications at xxxxx
Mon Jan 25 21:54:00 UTC 2016


>  	}
>  }
>  
> +/** Gets the GBoxed-derived GType for TMSourceFile
> + *
> + * @return TMSourceFile type . */
> +GEANY_API_SYMBOL
> +GType tm_source_file_get_type(void);

Am 25. Januar 2016 22:41:41 MEZ, schrieb Colomban Wendling <notifications at github.com>:
>>  	}
>>  }
>>  
>> +/** Gets the GBoxed-derived GType for TMSourceFile
>> + *
>> + * @return TMSourceFile type . */
>> +GEANY_API_SYMBOL
>> +GType tm_source_file_get_type(void);
>
>```gcc
>../../../tagmanager/src/tm_source_file.c:272:7: warning: redundant
>redeclaration of 'tm_source_file_get_type' [-Wredundant-decls]
> GType tm_source_file_get_type(void);
>       ^
>In file included from ../../../tagmanager/src/tm_source_file.c:35:0:
>../../../tagmanager/src/tm_source_file.h:48:7: note: previous
>declaration of 'tm_source_file_get_type' was here
> GType tm_source_file_get_type(void);
>       ^
>```
>but I guess we don't care.  Alternatively we could just rely on the
>fact `G_DEFINE_BOXED_TYPE` only expands to a function definition so
>attributes could come right before, but this is likely to be fragile as
>it's not documented explicitly.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/geany/geany/pull/839/files#r50760586

Actually I considered this. However I decided against for that reason, but also because other similar macros like G_DEFINE_TYPE don't work like this.

This warning is harmless and not enabled  by default  isn't it?

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/839/files#r50762313
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160125/de114cf1/attachment.html>


More information about the Github-comments mailing list