[Github-comments] [geany-plugins] geanypy: Update bundled ax_python_devel.m4 to latest upstream (#339)

[Colomban Wendling]

> As I see it, the `Makefile.am` changes are backward-compatible. Thus I am not sure where the problem lies?

It currently doesn't, I was just referring to possible future occurrences of a similar issue.

> A few comments:
 - You should not bundle (other projects) m4 files in Git; these files are considered as development files and should be included in the relevant `-dev(el)` packages in your favorite distro.

Well.  There's 2 problems here

1. can we rely on every distros having autoconf-archive packaged, and can we trust it will contain ax_python_devel.m4?
2. this would be a build dependency (from Git) no matter whether you want geanypy or not.
  - well, OK, we could use `m4_ifdef()` to conditionally use that.  But it would be one more possible reason why the plugin is not available, and a lot less straightforward than a normal build dep.

> - If you really *must* trick `aclocal`, you can increase the `#serial` line so that it always picks the one in the repo. But you should not.

Oh, so it looks at the serial?  I learned something :)

> - Do you really want Python 2 support? If not, I think Python 3 is distributed with a `pkg-config` file which you should definitely use. Maybe add a `./configure --with-python={2|3}` switch?

Hum, maybe. In Debian there's also a pkg-config file for python2.7.  Though, I don't think either one have the same information as the ones fetched by `ax_python_devel` -- but maybe they are just fine.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/339#issuecomment-172526587
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160118/56019b8a/attachment.html>