[Github-comments] [geany] Gboxed types (#839)

Colomban Wendling notifications at xxxxx
Mon Jan 18 00:33:22 UTC 2016


>  */
>  GEANY_API_SYMBOL
>  void tm_source_file_free(TMSourceFile *source_file)
>  {
> -	if (NULL != source_file)

This changes the contract of an API function: it used to be happy with a NULL source file, now it's not.  It should be fine as apparently neither Geany nor GP seem to rely on this, but I wonder if changing behavior has enough advantage to warrant a potentially breaking change.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/839/files#r49955549
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160117/1c440e3f/attachment.html>


More information about the Github-comments mailing list