[Github-comments] [geany-plugins] Add new "Lineoperations" plugin (#324)

[Colomban Wendling]

> +	/* Add an item to the Tools menu */
> +	main_menu_item = gtk_menu_item_new_with_mnemonic(_("Line Operations"));
> +	gtk_widget_show(main_menu_item);
> +	ui_add_document_sensitive(main_menu_item);
> +
> +	submenu = gtk_menu_new();
> +	gtk_widget_show(submenu);
> +	sep1 = gtk_separator_menu_item_new();
> +	sep2 = gtk_separator_menu_item_new();
> +	rmdupst_item  = gtk_menu_item_new_with_mnemonic(_("Remove Duplicate Lines, Sorted"));
> +	rmdupln_item  = gtk_menu_item_new_with_mnemonic(_("Remove Duplicate Lines, Ordered"));
> +	rmunqln_item  = gtk_menu_item_new_with_mnemonic(_("Remove Unique Lines"));
> +	rmemtyln_item = gtk_menu_item_new_with_mnemonic(_("Remove Empty Lines"));
> +	rmwhspln_item = gtk_menu_item_new_with_mnemonic(_("Remove Whitespace Lines"));
> +	sortasc_item  = gtk_menu_item_new_with_mnemonic(_("Sort Lines Ascending"));
> +	sortdesc_item = gtk_menu_item_new_with_mnemonic(_("Sort Lines Descending"));

Yeah, I guess it's acceptable (and several plugins already do that).  As you said, it can indeed be suboptimal as another plugin might have the same mnemonic as yours, but as @codebrainz said it wouldn't break things too bad either.
So IMO do as you like.  but maybe @frlan has a stronger opinion on that matter?

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/324/files#r49619471
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160113/5424b4c4/attachment.html>