[Github-comments] [geany] Rewrite scope completion 3 (#862)

[Jiří Techet]

>  
> -	tags = tm_workspace_find(name, tm_tag_max_t, NULL, FALSE, ft->lang);
> -	g_free(name);
> -	if (!tags || tags->len == 0)
> -		return;
> +	/* check if invoked on member */
> +	pos -= strlen(name);
> +	while (pos > 0 && isspace(sci_get_char_at(sci, pos - 1)))
> +		pos--;
> +	member = match_last_chars(sci, pos, ".") || match_last_chars(sci, pos, "::") ||
> +			 match_last_chars(sci, pos, "->") || match_last_chars(sci, pos, "->*");

Yeah, I somehow missed this one - will fix.

I might have a look at the code duplication later (though both parts of the code do a slightly different thing so it might lead to a bit unnatural code).

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/862/files#r49342988
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160111/3ec60f44/attachment.html>