[Github-comments] [geany] Rewrite scope completion 2 (#505)

[Colomban Wendling]

>  			pos--;
> -		else if (ft->id == GEANY_FILETYPES_CPP && pos >= 3 && match_last_chars(sci, pos, "->*"))
> +
> +		if (pos > 0)
> +			typed = sci_get_char_at(sci, pos - 1);
> +	}
> +
> +	if (typed == '.')
> +		pos -= 1;
> +	else if (ft->id == GEANY_FILETYPES_C || ft->id == GEANY_FILETYPES_CPP ||
> +		ft->id == GEANY_FILETYPES_PHP || ft->id == GEANY_FILETYPES_RUST)
> +	{
> +		if (match_last_chars(sci, pos, "::"))

just a thought: what about using `tm_tag_context_separator()` instead of checking for some filetypes?  Not sure it's sensible at all, but right now I see the check above will leave out GLSL, Zephir and PowerShell (not sure if it'd make sense for the latter, but definitely for the former two).

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/505/files#r49268284
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160109/617017a4/attachment.html>