[Github-comments] [geany] Fix 60 typos, point out 38 more (#849)

Colomban Wendling notifications at xxxxx
Wed Jan 6 13:33:56 UTC 2016


> ```
./tagmanager/ctags/vhdl.c:71: atribute  ==> attribute
./tagmanager/ctags/vhdl.c:71: atributes  ==> attributes
```

We can fix those, because upstream CTags doesn't have them, and they aren't used at all in fact.  Fixed in 4a2890667e47af88212819e85061948f82788ad5

> `./data/filetypes.fortran:7: inot  ==> into`
> `./data/filetypes.f77:23: inot  ==> into`

This actually isn't a typo.  AIUI it means "i not", which seems to be `not` on some some kind of short integer in Fortran. (see http://physik.uibk.ac.at/hephy/praktikum/fortran_manual.pdf, p195).

> `./data/php.tags:3358: lenght  ==> length`

This is auto-generated from PHP's docs, so we don't really want to fix this manually.  It's buggy uptream too in the signature: https://secure.php.net/manual/en/function.ps-open-image.php

> `(ignored, because these are "ancient" changelogs)` […]

We could fix those, but it probably doesn't matter much indeed.

> `(ignored, because these are very consistent)`

We could fix this too, but it's in a test file we didn't even write ourselves, so I'd just ignore those.

> `(ignored, because these are variable names)`

ditto

> ```
(ignored, because I don't wanna go full grammar-nazi on you)
./tests/ctags/3526726.tex:688: wont  ==> won't, wont
./tests/ctags/bug726712.f90:70: wont  ==> won't, wont
./tests/ctags/mode.php:97: WONT  ==> WON'T, WONT
./scintilla/src/ScintillaBase.cxx:279: Wont  ==> Won't, wont
./scintilla/src/ScintillaBase.cxx:308: Wont  ==> Won't, wont
```

Those are either in Scintilla (upstream project as @elextr pointed out), or in some test files, so I don't really care.  Though maybe a naive person not knowing "won't" might get confused as "wont" an actual word.  But well.

> `./tagmanager/src/tm_workspace.c:1172: wanna  ==> want to  | disabled because one might want to allow informal pronunciation`

I'd fix this one, but I'll leave it for now as another PR will remove the whole function and I don't want to create merge conflicts just for this.

---

BTW, thanks a bunch for this tireless hunting!

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/849#issuecomment-169323514
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160106/e41ecee1/attachment.html>


More information about the Github-comments mailing list