[Github-comments] [geany] Hang on "Reflow" with lots of spaces (#848)

Colomban Wendling notifications at xxxxx
Mon Jan 4 21:10:36 UTC 2016


> Also there is no need to strip trailing spaces, if the "strip trailing spaces" option is set then they go away when the file is saved anyway.

Tho it's annoying when it's not enabled, because reflow inserts a *lot* of trailing spaces.

> As for using anything other than ascii spaces for breaking, see the warning on the [link](https://developer.gnome.org/glib/stable/glib-Unicode-Manipulation.html#g-unichar-isspace) @codebrainz posted.

This is kinda irrelevant, it's not worse to use an ASCII version of `isspace()` than only the ASCII space character itself.  Sure, when it comes to real, locale-aware, word breaking, it's highly complicated, but we probably don't really want that anyway, and couldn't either (what language is this?  we don't know, and can only guess English).

> Reflowing something containing tabs is hard to understand, why use a tab internally unless you want something aligned, but then you ask for it to be un-aligned :smile:  I'm not sure what the "right" thing to do is, maybe better to not do anything special.

Well, okay maybe just leave it as is and leave people with the very weird behavior on tabs (probablt because it's *partially* considered spaces: it is for indentation and trailing space purpose, but not in the reflow algorithm itself).

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/848#issuecomment-168809861
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160104/1da72900/attachment.html>


More information about the Github-comments mailing list