[Github-comments] [geany] Store "equal" tags into binary trees instead of lists in Symbol tree (#797)

Colomban Wendling notifications at xxxxx
Sat Jan 2 17:46:25 UTC 2016


>  		}
> -		*list = g_list_prepend(*list, g_slice_dup(GtkTreeIter, iter));
> +
> +		gtk_tree_model_get(GTK_TREE_MODEL(store), iter, SYMBOLS_COLUMN_TAG, &tag, -1);

hum, actually unless I'm mistaken we can always use the same `TMTag` as for the name, it's has either been already updated in the store, or the old tag's line is the same (as of `tm_tag_equal()`).
So, I guess I'd rather simply go back to removing the `store`arg and receiving a `TMTag`, and use the latter both for name and line.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/797/files#r48686131
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160102/81021d28/attachment.html>


More information about the Github-comments mailing list