[Github-comments] [geany] Don't show the goto popup for typedef synonyms (#923)

Jiří Techet notifications at xxxxx
Mon Feb 29 13:20:58 UTC 2016


For instance when performing goto tag for Foo and Foo is defined as

typedef struct Foo {} Foo;

go immediately to the struct location without showing the goto popup with
both the struct name and typedef.

Note the missing

g_strcmp0(second->var_type, first->name) == 0

in the check - in this particular case we won't get the type to which the
typedef refers inside var_type because at the time the typedef tag is
generated in c.c the struct tag doesn't exist yet. On the other hand
there's no second->var_type == NULL either because this behaviour seems
to be rather implementation-specific and might easily change in the
future. The existing checks are probably sufficient for the real-world
code.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/923

-- Commit Summary --

  * Don't show the goto popup for typedef synonyms

-- File Changes --

    M src/symbols.c (12)

-- Patch Links --

https://github.com/geany/geany/pull/923.patch
https://github.com/geany/geany/pull/923.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/923
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160229/6793de97/attachment.html>


More information about the Github-comments mailing list