[Github-comments] [geany] If more tags are found during tag definition/declaration goto, let user select which one to use (#406)

Jiří Techet notifications at xxxxx
Thu Feb 18 21:26:22 UTC 2016


@b4n I tested your patches and things look pretty great. I have also addressed your comments and pushed the changes here:

https://github.com/techee/geany/tree/multi_tag_goto_2

The only thing I didn't like much was that on Ctrl+click the first item isn't selected - I think even when using Ctrl+click one should be able to just press enter to go to the first, suggested, tag. I removed the special case in the penultimate patch in the branch above.

The second problem is that the push_in parameter causes this:

![screenshot_2016-02-18_21-54-31](https://cloud.githubusercontent.com/assets/713965/13158613/00b47eda-d68e-11e5-8107-45f4425ff8cd.png)

I think I prefer push_in = FALSE, which I did in the last patch and which, while not ideal, looks this way:

![screenshot_2016-02-18_21-53-13](https://cloud.githubusercontent.com/assets/713965/13158676/5320ac48-d68e-11e5-8255-708f13caa0ab.png)

(It would be best to have the popup over the whole screen like in the first screenshot but filled with all the values without the empty space.)


---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406#issuecomment-185929820
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160218/54aba108/attachment.html>


More information about the Github-comments mailing list