[Github-comments] [geany-plugins] Macro plugin compatibility for both gtk2 and gtk3 [Needs Testing] (#352)

[Colomban Wendling]

> @@ -1733,9 +1736,12 @@ static void EditMacroElements(Macro *m)
>  
>  	/* create dialog box */
>  	cTitle=g_strdup_printf(_("Edit: %s"),m->name);
> -	dialog=gtk_dialog_new_with_buttons(cTitle,GTK_WINDOW(geany->main_widgets->window),
> -		GTK_DIALOG_DESTROY_WITH_PARENT,NULL);
> -
> +	dialog=gtk_dialog_new();
> +    //_with_buttons(cTitle,GTK_WINDOW(geany->main_widgets->window),
> +		//GTK_DIALOG_DESTROY_WITH_PARENT,NULL);
> +    gtk_window_set_title(GTK_WINDOW(dialog), cTitle);
> +    gtk_window_set_transient_for(GTK_WINDOW(dialog), GTK_WINDOW(geany->main_widgets->window));
> +    gtk_window_set_destroy_with_parent(GTK_WINDOW(dialog), TRUE);

what was the problem with the `_with_buttons()` call, but with 0 buttons?

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/352/files#r53330997
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160218/52fb3885/attachment.html>