[Github-comments] [geany] If more tags are found during tag definition/declaration goto, let user select which one to use (#406)

[Colomban Wendling]

> +	gtk_tree_model_get_iter(model, &iter, path);
> +	gtk_tree_model_get(model, &iter, TAG_COLUMN, &tag, -1);
> +	g_return_if_fail(tag);
> +
> +	new_doc = document_find_by_real_path(tag->file->file_name);
> +	if (!new_doc)
> +		new_doc = document_open_file(tag->file->file_name, FALSE, NULL, NULL);
> +
> +	if (new_doc)
> +	{
> +		GeanyDocument *old_doc = document_get_current();
> +
> +		navqueue_goto_line(old_doc, new_doc, tag->line);
> +	}
> +
> +	gtk_widget_hide(tag_goto_popup);

the whole store should probably be cleared when hiding, not to keep TMTags around for no reason.  note: destroying the popup would take care of this.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406/files#r52834451
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160213/230ad664/attachment.html>