[Github-comments] [geany] If more tags are found during tag definition/declaration goto, let user select which one to use (#406)

Colomban Wendling notifications at xxxxx
Sat Feb 13 21:55:27 UTC 2016


> +
> +static void on_row_activated(GtkTreeView *tree_view, GtkTreePath *path,
> +	GtkTreeViewColumn *column, gpointer user_data)
> +{
> +	GtkTreeModel *model = gtk_tree_view_get_model(tree_view);
> +	GeanyDocument *new_doc;
> +	GtkTreeIter iter;
> +	TMTag *tag;
> +
> +	gtk_tree_model_get_iter(model, &iter, path);
> +	gtk_tree_model_get(model, &iter, TAG_COLUMN, &tag, -1);
> +	g_return_if_fail(tag);
> +
> +	new_doc = document_find_by_real_path(tag->file->file_name);
> +	if (!new_doc)
> +		new_doc = document_open_file(tag->file->file_name, FALSE, NULL, NULL);

won't that change what is the "current" document below, and then lead to a weird sequence in the location history?

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/406/files#r52834183
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160213/fa243688/attachment.html>


More information about the Github-comments mailing list