[Github-comments] [geany] Gtkdoc hdr (#890)

[Colomban Wendling]

>  
> -all-local: Doxyfile.stamp
> +Doxyfile.stamp: Doxyfile Doxyfile-gi $(doxygen_sources)
> +	$(AM_V_GEN)$(DOXYGEN) Doxyfile-gi && $(DOXYGEN) Doxyfile && echo "" > $@
> +
> +ALL_TARGETS = Doxyfile.stamp
> +
> +if WITH_PYTHON
> +
> +geany-scintilla-gtkdoc.h: geany-gtkdoc.h
> +
> +geany-gtkdoc.h: Doxyfile.stamp $(top_srcdir)/scripts/gen-api-gtkdoc.py
> +	$(AM_V_GEN)$(top_srcdir)/scripts/gen-api-gtkdoc.py xml -d $(builddir) \
> +	-o geany-gtkdoc.h --sci-output geany-scintilla-gtkdoc.h

this doesn't properly check for failure.  Something like this is needed:
```diff
diff --git a/doc/Makefile.am b/doc/Makefile.am
index 3396063..1f97e4c 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -123,7 +123,8 @@ geany-scintilla-gtkdoc.h: geany-gtkdoc.h
 
 geany-gtkdoc.h: Doxyfile.stamp $(top_srcdir)/scripts/gen-api-gtkdoc.py
     $(AM_V_GEN)$(top_srcdir)/scripts/gen-api-gtkdoc.py xml -d $(builddir) \
-    -o geany-gtkdoc.h --sci-output geany-scintilla-gtkdoc.h
+    -o geany-gtkdoc.h --sci-output geany-scintilla-gtkdoc.h \
+    || { $(RM) geany-gtkdoc.h geany-scintilla-gtkdoc.h && exit 1; }
 
 ALL_TARGETS += geany-gtkdoc.h geany-scintilla-gtkdoc.h
 
```

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/890/files#r52648965
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160211/1d740447/attachment.html>