[Github-comments] [geany] Gtkdoc hdr (#890)

[Colomban Wendling]

> +		for n in xml.getchildren():
> +			if n.tag == "emphasis":
> +				s += self.at.cb("a", self.__process_element(n))
> +			if n.tag == "computeroutput":
> +				s += self.at.cb("c", self.__process_element(n))
> +			if n.tag == "itemizedlist":
> +				s += "\n" + self.__process_element(n)
> +			if n.tag == "listitem":
> +				s += " - " + self.__process_element(n)
> +			if n.tag == "para":
> +				s += self.__process_element(n) + "\n"
> +			if n.tag == "ref":
> +				s += n.text if n.text else ""
> +			if n.tag == "simplesect":
> +				ss = self.at.cb(n.get("kind"), self.__process_element(n))
> +				s += ss if ss + "\n" else ""

looks wrong, as it's a convoluted way to write `ss` (as adding the `"\n"` in the test makes it evaluate to true).  Shouldn't the `\n` be added on the other value rather than the test?

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/890/files#r52641182
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160211/f5f6bb8c/attachment.html>