[Github-comments] [geany/geany-plugins] geanylua: Fix build with latest Scintilla (#510)

Colomban Wendling notifications at xxxxx
Tue Dec 6 19:29:53 UTC 2016


When not defining `INCLUDE_DEPRECATED_FEATURES`, unprefixed structure names are not available anymore.  Thus, use prefixed names.


---
Since the last Scintilla update in Geany (3.7.1) unprefixed structure names are hidden.  This is good in theory, and will avoid thinks like 87d4bbcd16a41fce93b7da20c2135ff728b25791 in the future, but GeanyLua used unprefixed names.

So, in addition to the fix, do we want to restore the old names, or break API to reflect those are now removed, or do we consider it's not part of our API and thus don't care?  Of course as it's a structure name, it only affects building the code, the generated one is still binary compatible anyway.
@elextr @codebrainz @frlan 
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/510

-- Commit Summary --

  * geanylua: Fix build with latest Scintilla

-- File Changes --

    M geanylua/glspi_sci.c (4)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/510.patch
https://github.com/geany/geany-plugins/pull/510.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/510
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161206/c52fd2bf/attachment.html>


More information about the Github-comments mailing list