[Github-comments] [geany/geany] Support for VTE 2.91 (#1181)

[Colomban Wendling]

> Also shouldn't the use of `vte_terminal_im_append_menuitems()` be just dropped?

I'm not sure.  At least on GTK2 I think widgets were supposed to display a way to select the input method -- just right click on any GtkEntry from a GTK2 app and you'll see the item.  Apparently it was [removed from GTK 3.10 somehow](https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-show-input-method-menu), but I have no idea hos it works now -- well, nor before, I don't know anything about input methods.  But if it's something the widget has to implement another way (say, an interface so GTK can do some magic on its side), we'd need to be sure not to remove the element from a VTE that doesn't have that other thing.

Basically, as said in my first comment on #336 I don't really know hot to deal with this removal, and while it seems that on recent GTK3 version it's not needed (or not displayed?), I wouldn't remove it on other VTE versions unless I actually *knew* what I was changing.
And no, commit that removes this on the VTE repo isn't clear: [2da7058c57fd27bb8a8955b50a7a5b2ae8e6d50f deprecated it](https://git.gnome.org/browse/vte/commit/?id=2da7058c57fd27bb8a8955b50a7a5b2ae8e6d50f) and [985fd375c25345933bcd864d4c8be302c3a54eb8 removed it](https://git.gnome.org/browse/vte/commit/?id=985fd375c25345933bcd864d4c8be302c3a54eb8).

Writing this, I dug in GTK docs, and I'd think that since 3.10 widgets aren't supposed to show a way of switching the input method, and I guess instead the DE is supposed to handle that globally somehow.  But that's still a guess.

Possibly we should show this item on GTK < 3.10, and surely not show it if [`gtk-show-input-method-menu`](https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-show-input-method-menu) is set to `FALSE`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1181#issuecomment-241398561
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160822/9ade16f1/attachment.html>