[Github-comments] [geany/geany] Support for VTE 2.91 (#1181)

[Colomban Wendling]

> @@ -221,6 +224,78 @@ WRAP_RGBA_SETTER(vte_terminal_set_color_foreground)
>  #endif
>  
>  
> +#if GTK_CHECK_VERSION(3, 0, 0)
> +static void default_vte_terminal_set_background_image_file(VteTerminal *terminal, const char *path)
> +{
> +	if (background_image_pixbuf)
> +	{
> +		g_object_unref(background_image_pixbuf);
> +		background_image_pixbuf = NULL;
> +	}
> +
> +	if (path != NULL)

Should allow for an empty `path` as none, as the setting will be the empty string rather than NULL, so this will lead to try and open file `""` and lead to a warning.

BTW, apparently VTE's implementation of this fails silently when the file can't be open/open as an image.  Warning is better for us I suppose, though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1181/files/e48fa14aa403c35833a5f4f6e11ab2a6ad6482cb..2bfcbe8c4bb501972b813b25f753a8e0781e0f1b#r75579707
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160820/31ba53ef/attachment.html>