[Github-comments] [geany/geany] Make document_rename_file() return a gboolean; Abort save if rename fails (#1180)

[elextr]

> I find that unnecessary overkill. ....

Maybe I wasn't clear, thats not a proposal, that is what happens now with those settings, we have no choice, its what the Glib and GIO libraries do.  And yes, all the possible problems you mention can happen.  For more information you can look at my [PHD thesis](https://wiki.geany.org/config/all_you_never_wanted_to_know_about_file_saving) :)

Hmmm, thinking about it again, the Glib and GIO saving methods were not available back when this was first added (see below), so it wasn't quite as ridiculous then, but would still have been better to save and then delete the original.

>  "Save and R_emove Original"

Nice suggestion, same mnemonic and all.  And rename  _was_ originally a checkbox IIRC and was changed to a button (waaaaay back in 2007 or so, I suddenly feel olde) so I doubt anyone will suggest changing it back.

> ... in place renaming ...

Yes separating rename and save is a better idea still.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1180#issuecomment-240961916
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160819/b393b3d1/attachment.html>