[Github-comments] [geany/geany] Better check for a file change on disk by also monitoring the file size. (#1175)

[elextr]

>  If file size on disk changes the file has been changed and Geany does not notice this (regardless any use-cases)!

Agreed, and its great that you offered a pull request.  The discussion is not about that, but the benefits.

As I said there have been problems in the past with change detection, with things like the failure of notification based detection, the need to separate GIO operations and Clib operations, and having to not mix their code paths. So I have some concern that the change should be tested in more than the local disk case, which always worked, all the time, as expected.  This essentially means in various networked environments (SSHFS anybody), and in Windows and SMB shares. None of these are the normal environment for Geany devs, so it costs them time and effort to set up and test it, or to find other contributors to do so.  

It is perfectly understandable that you would not count that cost when you initially raised the "simple" PR, but it is something project contributors need to consider and weigh against the risks and benefits of the change.

So it is perfectly reasonable to enquire how much of a benefit the change brings and if there is an easy workaround if its not applied.  That allows people to see how many others might benefit, to see how much effort needs to be applied and how urgently, especially as there is not (that I could find) an existing issue that indicates a need for the change.

I'm sorry that you made your first contribution in a sensitive area and found unexpected questioning of the need for it, but I hope the extended explanation helps you to understand the other side.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1175#issuecomment-239615775
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160813/69b4917b/attachment.html>