[Github-comments] [geany/geany] Search: Add help buttons to the dialogs (#1169)

Colomban Wendling notifications at xxxxx
Mon Aug 8 23:58:03 UTC 2016


Add a Help button to *Find*, *Replace* and *Find in Files* dialogs.

![find](https://cloud.githubusercontent.com/assets/793526/17500228/f456727e-5dd3-11e6-9288-c139e1caf114.png)
![replace](https://cloud.githubusercontent.com/assets/793526/17500226/f44ef4f4-5dd3-11e6-83b6-bbe1d71d2f3f.png)
![fif](https://cloud.githubusercontent.com/assets/793526/17500227/f453231c-5dd3-11e6-8263-b8f50fe054d7.png)

The *Replace* dialog might be a problem because it has many buttons, so it takes a lot of place.  It's a little better when icons on buttons are not shown (which is the default under GNOME, but not MATE AFAIK), but it's worse in some locales where the *Search & Replace* label takes more space.  Opinions?


---
BTW, one can see that we have a *Close* button for *Find* and *Replace*, but a *Cancel* one for *Find in Files*.  Looks odd.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1169

-- Commit Summary --

  * Simplify and unify code for opening the help
  * Add a help button to the Find dialog
  * Add a help button to the Replace dialog
  * Add a help button to the Find in Files dialog

-- File Changes --

    M src/callbacks.c (6)
    M src/prefs.c (5)
    M src/search.c (12)
    M src/utils.c (12)
    M src/utils.h (2)

-- Patch Links --

https://github.com/geany/geany/pull/1169.patch
https://github.com/geany/geany/pull/1169.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1169
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160808/3dbd8925/attachment.html>


More information about the Github-comments mailing list