[Github-comments] [geany/geany] Ctags sync, part 1 (#1160)

[Matthew Brush]

> +# endif
> +#endif
> +
> +#ifdef HAVE_DIRECT_H
> +# include <direct.h>  /* to _getcwd */
> +#endif
> +#ifdef HAVE_DIR_H
> +# include <dir.h>  /* to declare findfirst() and findnext() */
> +#endif
> +#ifdef HAVE_IO_H
> +# include <io.h>  /* to declare open() */
> +#endif
> +#include "debug.h"
> +#include "routines.h"
> +#ifdef HAVE_ICONV
> +# include "mbcs.h"

> I indeed don't think it's valid to just define HAVE_ICONV and whine it breaks

Agree, since it appears to not be in public (TM) headers. If it was, I could imagine a plugin defining it if it used libiconv and causing trouble.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1160/files/d440a81166e62d41e2b06d555b471db5fdd8d80d..ea72ecc00fc22f24eced3ffce7c7db67d5f02271#r73970836
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160808/18aa0ed5/attachment.html>