[Github-comments] [geany/geany] Ctags sync, part 1 (#1160)

[Jiří Techet]

> +# endif
> +#endif
> +
> +#ifdef HAVE_DIRECT_H
> +# include <direct.h>  /* to _getcwd */
> +#endif
> +#ifdef HAVE_DIR_H
> +# include <dir.h>  /* to declare findfirst() and findnext() */
> +#endif
> +#ifdef HAVE_IO_H
> +# include <io.h>  /* to declare open() */
> +#endif
> +#include "debug.h"
> +#include "routines.h"
> +#ifdef HAVE_ICONV
> +# include "mbcs.h"

> Hum… is general.h not going to get merged? I mean, this is the current only use of this macro, and if this file isn't added an the macro not used in other synced code, I don't see why have this some place else than here.

We'll have some diffs against uctags e.g. to install our tag hook anyway so this could be one of the additional differences. In uctags #ifdef HAVE_ICONV is checked at quite many places so it's probably better to have it undefined once in general.h than having to do something at every place it appears.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1160/files/d440a81166e62d41e2b06d555b471db5fdd8d80d..ea72ecc00fc22f24eced3ffce7c7db67d5f02271#r73967182
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160808/60d9d137/attachment.html>