[Github-comments] [geany/geany] Ctags sync, part 1 (#1160)

[Colomban Wendling]

regarding whitespace changes: I didn't give it a shot yet, but normally Git should be very useful to review those.  If they are only indentation changes, `git show -b` should show an empty diff.  And oddly enough I'd trust Git :)

Regarding memory allocation variants: I don't care so long as as @elextr the deallocator matches (even though nowadays GLib's will always match libc's, it'd be poor design to mix them).  But remember that GLib's abort on allocation failure, while libc's just return NULL.  I think CTags has wrapper for that itself, but it's an important difference.

About regex, well… the problem is that we'd need a bundled version of GNU regex, and that would mean keeping it up to date.  If you really wanna do that, maybe "just" write a tiny wrapper using GRegex in a compatible API?  I'm kinda afraid of having to keep a copy of GNU regex -- and it's especially ironic when it's in the process of syncing another lib :)

Regarding the HTML parser, yeah a non-regex one would probably be better, and indeed fairly easy to write.  UCTags has even added libxml-based parsers, so maybe it could use that if we didn't care about the dep (FWIW, we already indirectly link to libexpat).

That said, let's get to the meat of this.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1160#issuecomment-237545634
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160804/714a6668/attachment.html>