[Github-comments] [geany/geany] Ctags sync, part 1 (#1160)

Jiří Techet notifications at xxxxx
Thu Aug 4 10:17:30 UTC 2016


> ...poor @b4n really can't be expected to review it. There has got to be a better way, what about doing the whitespace first then? That will have no code changes and would be more reasonably reviewable and could even be a few files at a time.

Reviewing it through "Files changed" would be crazy and would indeed be unreviewable. But it can be easily reviewed patch by patch - if you simply click the whitespace patch above, you get

https://github.com/geany/geany/pull/1160/commits/6bc579798716dbe94a171a016f9989c92c4b67e2

which is quite obvious (well, the github diff implementation screws up from time to time and doesn't show the same lines next to each other but there are not so many of those). Reviewing the patches individually is the same as if I created several pull requests (which isn't easily doable because of the patch dependency as I explained).

So I hope our poor old @b4n won't suffer much :-).


---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1160#issuecomment-237513070
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160804/a4880b52/attachment.html>


More information about the Github-comments mailing list