[Github-comments] [geany/geany] Ctags sync, part 1 (#1160)

[Jiří Techet]

> So why bother at all? Don't make extra work for yourself and others :) Especially just for whitespace :) And if it causes conflicts with real changes, more reason to drop or delay the whitespace fixes.

You don't see the whole picture. My setup to do this work looks like this:

- one Geany window with project containing Geany
- one Geany window with project containing ctags
- one Meld window with geany/ctags/parsers vs ctags/parsers diff
- one Meld window with geany/ctags/main vs ctags/main diff

and diffs are all over the place in Meld. I try to make some sense from the diffs and seeing 3700 lines less of diffs makes a huge difference for me. Also, if I didn't make the whitespace change now, every time I would copy/paste some code from uctags to Geany I would have to convert it into the old ctags indentation style if I want to have a consistent state after every commit (which I do).

The patches here don't make much sense by themselves, you'll only see the "why" part after you diff the result to uctags.

> One concern I have with this whole process is its gonna come to a screaming halt at c.c and not get completed, preventing us from getting most of the benefit of upstream compatibility. IIUC the geany version of c.c has several extra languages mixed into it. Maybe that should be looked at first.

Right, c.c is the only file file that will probably not get merged (by me at least, this is the only file except the autotools stuff I fear in Geany - but @elextr, it sounds like a challenge for you :-). The thing is it's not c.c where the main development happens in uctags - it's the completely new c/c++ parser here:

https://github.com/universal-ctags/ctags/tree/master/parsers/cxx

So at some point we could switch to the new uctags parser for c/c++ and keep our c.c for the rest (my guts feeling is our c.c is better than the uctags one).

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1160#issuecomment-237473355
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160804/20b17c27/attachment.html>