[Github-comments] [geany] Proxy plugins (#629)

[Colomban Wendling]

>  			PLUGIN_COLUMN_CHECK, state,
>  			PLUGIN_COLUMN_PLUGIN, p, -1);
>  
>  		/* set again the sensitiveness of the configure and help buttons */
>  		pm_update_buttons(p);
> +
> +		/* Depending on the state disable the checkbox for the proxy of this plugin, and
> +		 * only re-enable if the proxy is not used by any other plugin */
> +		if (p->proxy != &builtin_so_proxy_plugin)
> +		{
> +			GtkTreeIter parent;
> +			gboolean can_uncheck;
> +			GtkTreePath *store_path = gtk_tree_model_filter_convert_path_to_child_path(
> +			                                GTK_TREE_MODEL_FILTER(model), path);

are we sure the path is still the same?  I could imagine not if e.g. the plugin changed name upon reload maybe

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/629/files#r40364858
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20150924/156c345c/attachment.html>