[Github-comments] [geany] Enhance detection of sh functions (#661)

konsolebox notifications at xxxxx
Thu Sep 24 07:59:23 UTC 2015


Bash allows more characters besides `[[:alnum:]_]` when declaring
function names using the `function` keyword.  It also does not require
having a pair of parentheses after the name.  Some shells may actually
implement it differently but we don't have to be that strict since the
user explicitly specifies the `function` keyword anyway.

This update implements the one described above, and also invalidates
function names that are completely made up of digits.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/661

-- Commit Summary --

  * Enhance detection of sh functions

-- File Changes --

    M tagmanager/ctags/sh.c (124)

-- Patch Links --

https://github.com/geany/geany/pull/661.patch
https://github.com/geany/geany/pull/661.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/661
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20150924/47350dcf/attachment.html>


More information about the Github-comments mailing list