[Github-comments] [geany] Fix configdir encoding (#658)

zhekov notifications at xxxxx
Fri Sep 18 16:50:38 UTC 2015


configdir is initially in locale (glib) encoding. Converting it from UTF-8 is wrong (for example, "Р±РѕР·Р°" becomes "боза" on my system), and it must be converted _to_ UTF-8 when used in geany_debug() - otherwise, Help -> Debug Messages terminates Geany with an assertion. This is for POSIX only, under Windows the glib encoding is also UTF-8.

I replaced "alternate configdir %s" and "creating config directory %s" with static texts, because the directory is shown shortly after them as "User config dir: %s" anyway, and I don't want to create and free an utf8_configdir two more times.

dialogs_show_msgbox() in create_config_dir() are for the default directory only, and thus do not require conversion.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/658

-- Commit Summary --

  * Fix configdir encoding

-- File Changes --

    M src/libmain.c (12)

-- Patch Links --

https://github.com/geany/geany/pull/658.patch
https://github.com/geany/geany/pull/658.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/658
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20150918/26804e52/attachment.html>


More information about the Github-comments mailing list