[Github-comments] [geany-plugins] Addons bookmark refresh fix (#284)

[Enrico Tröger]

Update bookmark list also on any line changes in the document

In addition to updating the bookmark list on document notebook tab change
and adding/removing line markers, also rebuild the bookmark list
when the text in the document changes with lines added or deleted.

Should fix SF bugs 129 and 39.

This implements some ideas mentioned in the above bug reports like updating the bookmark list
in an idle callback. Additionally, the list store is detach from the GtkTreeView to increase performance on big bookmark lists.

Maybe it is still worth to add a refresh button (or rather a context menu item to refresh) but I would try it without at first.

There is one issue left: if the `Transpose current line` feature is used, the bookmarks don't update. But this is not a problem in the plugin but rather in either Geany or Scintilla as the marker also stays at the "old" line. This should be managed separately.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/284

-- Commit Summary --

  * Move bookmark list refresh into an idle callback
  * Detach and re-attach the GtkTreeView model when updating
  * Update bookmark list also on any line changes in the document

-- File Changes --

    M addons/src/ao_bookmarklist.c (66)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/284.patch
https://github.com/geany/geany-plugins/pull/284.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/284
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20150916/0c641d65/attachment.html>