[Github-comments] [geany] Fix for "Open in New Window". (#637)

[zhekov]

@codebrainz 

> It would be easier to review (and look back to later) if it was broken down into the general stages of the change, like in a few different commits.

It can be broken into the following steps:

- Add the option reproducer to libmain and export main_get_persistent_argv (or however we call it)

- Alter utils_resource_dir -> utils_resource_path to support RESOURCE_FILE_GEANY (or however we call it)

- Rewrite utils_start_new_geany_instance() - this uses the above and must be the last one.

> the stuff with the options lookup table, and new globals, functions, and data types (change 3..N) seems like a lot of complexity (though it may indeed be warranted)

I'm not aware of an easier way to properly reproduce part of the options. Well, GeanyOptionEntryAux can be replaced with a const char *const with the short options that must be persistent, but that would be less clear.

> and the part that guards out the is_osx_bundle() seems unrelated

Really. I saw a warning "unused function" under Win~1, and instintively fixed it...
Can you please apply this change only to Geany?

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/637#issuecomment-137814146
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20150904/ab929226/attachment.html>