[Github-comments] [geany] Fix for "Open in New Window". (#637)

[Colomban Wendling]

> I like the fact that it uses the `spawn_*()` API now, instead of `g_find_program_in_path()` + `utils_spawn_*()` (change 1), and agree with the changes from @b4n's PR that it incorporates getting the installed/resource binary path (change 2, without using his commit+attribution), but the stuff with the options lookup table, and new globals, functions, and data types (change 3..N) seems like a lot of complexity (though it may indeed be warranted), and the part that guards out the `is_osx_bundle()` seems unrelated (change N+1).

Agreed.

Anyway, I don't have a strong opinion on this whole new window discussion, any solution that give a reasonably consistent user experience is fine with me.  This particular PR seem to properly restore all meaningful arguments so the new instance behaves as closely as the original one as possible, so that's nice.
Also, the result seem to make sense -- though I have yet to test it.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/637#issuecomment-137446323
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20150903/9658c1a4/attachment.html>