[Github-comments] [geany] Fix for "Open in New Window". (#637)

[Matthew Brush]

> are there any notes on the logic of this attempt to fix the "New Window" function

I like the end result.

It would be easier to review (and look back to later) if it was broken down into the general stages of the change, like in a few different commits. I like the fact that it uses the `spawn_*()` API now, instead of `g_find_program_in_path()` + `utils_spawn_*()` (change 1), and agree with the changes from @b4n's PR that it incorporates getting the installed/resource binary path (change 2, without using his commit+attribution), but the stuff with the options lookup table, and new globals, functions, and data types (change 3..N) seems like a lot of complexity (though it may indeed be warranted), and the part that guards out the `is_osx_bundle()` seems unrelated (change N+1).

Because of the above I have not done a thorough code review and likely won't merge it myself, but I'm +1 for the end result in general.

> The ultimate Right Thing for that will be to open a new window in the same process, but that will take time, and we have to patch "New Window" somehow until then.

Agree, there's no point holding off on an intermediate solution until we endeavour to improve the underlying implementation enough to support the ideal solution.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/637#issuecomment-137294359
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20150902/f0c61322/attachment.html>