[Github-comments] [geany] Adding more/missing file extensions and beginning manpage support (#718)

[elextr]

> Sorry, I should have been more clear. The manpage highlighting may not work because I do not know how to add the Scintilla lexer. I added the file extensions and keywords so that it would be easier for someone to add the lexer.

Lexers are written in C++, and AFAICS Scintilla doesn't have a manpage one, so you would need to write it.  You could try an existing lexer to see if it works "well enough", though to be honest I don't know which one to suggest.  Without a lexer or parser the filetype doesn't do much, so I don't know if we would add it.

> Other GitHub projects I have helped with liked all my changes to come as one commit. I will redo the changes to comply with Geany's project standards.

NP, the idea is that separate things be separate PRs so any questionable things can be discussed without holding up things that could be accepted immediately.

Splitting up the extensions is simply so they can be described in the commit message "Added extensions for XXX, see (some reference that its a valid extension)" without the commit message getting too long by describing lots in the one message.

> By the way, should I use the "ci skip" flag when committing changes to the filetype_extensions.conf file?

Since nothing is built from `filetype_extensions.conf` and no tests use it then it is probably nice to save a few Travis compute cycles.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/718#issuecomment-152770306
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151031/d2ce30a6/attachment.html>