[Github-comments] [geany] Proxy plugins (#629)

[Colomban Wendling]

> +{
> +	PluginContext *data;
> +	gchar fmt[] = "item%d";
> +	gint i = 0;
> +	gchar *text;
> +
> +	data = (PluginContext *) pdata;
> +
> +	/* Normally, you would instruct the VM/interpreter to call into the actual plugin. The
> +	 * plugin would be identified by pdata. Because there is no interpreter for
> +	 * .ini files we do it inline, as this is just a demo */
> +	data->help_text = g_key_file_get_locale_string(data->file, "Help", "text", NULL, NULL);
> +	while (TRUE)
> +	{
> +		GtkWidget *item;
> +		gchar *key = g_strdup_printf(fmt, i++);

`fmt` should be the string literal itself.  the variable is not needed, and it prevents GCC from checking the format string.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/629/files#r41062535
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151002/dd6fbf5a/attachment.html>