[Github-comments] [geany-plugins] Automake (#277)

[Colomban Wendling]

> @@ -0,0 +1,15 @@
> +if ENABLE_COMMANDER
> +geanyplugins_LTLIBRARIES += %D%/commander.la
> +
> +%C%_commander_la_SOURCES  = %D%/commander-plugin.c
> +%C%_commander_la_CPPFLAGS = $(AM_CPPFLAGS) \
> +                        -DPLUGIN=\"commander\" \
> +                        -DG_LOG_DOMAIN=\"Commander\"
> +%C%_commander_la_CFLAGS   = $(AM_CFLAGS) \
> +                        $(COMMANDER_CFLAGS)
> +%C%_commander_la_LIBADD   = $(COMMONLIBS) \
> +                        $(COMMANDER_LIBS)
> +
> +endif
> +
> +%C%_commander_la_SHORTNAME = commander_la

this most probably should be set for all plugins, it's too easy to miss when adding plugin-specific `CFLAGS`, especially as the difference is quite subtle.  Though OK, it's not *that* important, only means building in different directories doesn't generate the same-named object files, but that'd still be annoying.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/277/files#r46149869
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151130/1aeb7e7b/attachment.html>