[Github-comments] [geany] Minor highlighting issues in C and Python (#748)

Devyn Collier Johnson notifications at xxxxx
Tue Nov 10 16:05:00 UTC 2015


[ci skip]

- Added the missing "FileNotFoundError" exception to "identifiers="

Now, that exception will be highlighted like other exceptions.

- Added "bool", "true", and "false" to "primary=" in filetypes.c.

This addition was suggested by Colomban Wendling and Devyn Collier Johnson in the mailing list. As Colomban Wendling said -

>"This said, we could probably indeed have 'bool', 'false' and 'true' in filetypes.c's 'primary=' list (especially as we do have 'FALSE' and 'TRUE' which aren't even defined in standard C).  Technically those aren't keywords [1], but I guess it'd be convenient to have them -- yet one has to remember those are library extensions only available through stdbool.h.
>
>[1] see i.e. section 6.4.1ยง1 in the ISO/IEC 9899:201x n1570 draft"

In addition, "bool" is a macros expansion of _Bool, which is a data-type. Personally, I find it annoying and odd-looking for "bool" to not be highlighted. True, it is not in the core "C language", but it is in the Standard C Library (stdbool.h).
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/748

-- Commit Summary --

  * Update filetypes.c
  * Update filetypes.python

-- File Changes --

    M data/filetypes.c (2)
    M data/filetypes.python (2)

-- Patch Links --

https://github.com/geany/geany/pull/748.patch
https://github.com/geany/geany/pull/748.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/748
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151110/80a2461a/attachment.html>


More information about the Github-comments mailing list