[Github-comments] [geany] Fix known memory leak in win32_show_folder_dialog() (#812)

Colomban Wendling notifications at xxxxx
Mon Dec 14 15:32:42 UTC 2015


> @@ -284,7 +284,7 @@ INT CALLBACK BrowseCallbackProc(HWND hwnd, UINT uMsg, LPARAM lp, LPARAM pData)
>  gchar *win32_show_folder_dialog(GtkWidget *parent, const gchar *title, const gchar *initial_dir)
>  {
>  	BROWSEINFOW bi;
> -	LPCITEMIDLIST pidl;
> +	LPITEMIDLIST pidl;

Hum… can't figure out what the heck this should be from the docs, so I ask here: why change this (and what are those?)
The docs suggests it returns a `PIDLIST_ABSOLUTE`, which doesn't really help…

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/812/files#r47510881
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151214/b0077ade/attachment.html>


More information about the Github-comments mailing list