[Github-comments] [geany] Use multi-byte variant of CreateProcess on Windows (#809)

Enrico Tröger notifications at xxxxx
Sun Dec 13 16:13:50 UTC 2015


This should fix problems when the command line or the working directory
of a command on Windows contains non-ASCII characters.
Those characters are first converted into a multi-byte string and then
passed to CreateProcessW().

Closes #784.

I hope this won't have any unwanted side-effects. My tests were successfully and it solves the problem reported in #784.
The error handling seems a bit weird but actually works. The error strings are not marked as translatable on purpose because a) they are very technically and b) unlikely to happen at all.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/809

-- Commit Summary --

  * Use multi-byte variant of CreateProcess on Windows

-- File Changes --

    M src/spawn.c (29)

-- Patch Links --

https://github.com/geany/geany/pull/809.patch
https://github.com/geany/geany/pull/809.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/809
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151213/f491f231/attachment.html>


More information about the Github-comments mailing list